https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136304|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Created attachment 136325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136325&action=edit Bug 30960: Don't allow user to place the hold without a pick-up place It's possible to place item-level hold without selecting a pick-up location, which causes problems: if the item is then returned, Koha tells about a hold, but gives error 500. At customer's hold tab you see the number of holds, but cannot see the actual holds there. However, if you go to the title in question, then modify the hold so that it has a pick-up place, then the hold will work normally again. This patch fixes already existing but not working js error message and ensures that hold cannot be made while pickup location is undefined. To reproduce: 1. Go to admin page, to the libraries configurations, and disable pickup location for one of them. 2. Pick any biblio that has items that have that same library as a default pickup location. 3. When placing the item-level hold, notice that the pickup location dropdown box is empty by default. Keep it empty, place the hold. 4. Go to the patron's page of the patron who you placed that hold for, check that it doesn't show the new hold. 5. Apply patch. 6. Repeat steps 2 and 3, it shouldn't let you make the item-level hold until you select a specific pickup location. Signed-off-by: David Nind <da...@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer...@web.de> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/