https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Hi David, the QA test tools turn up some issues with this patch, can you please fix? 1) QA test tools FAIL Koha/SearchEngine/Elasticsearch.pm FAIL spelling prefered ==> preferred OK Koha/SearchEngine/Elasticsearch/Search.pm FAIL catalogue/search.pl FAIL critic # ControlStructures::ProhibitMutatingListFunctions: Got 1 violation(s). # Variables::ProhibitUnusedVariables: Got 1 violation(s). OK installer/data/mysql/atomicupdate/bug_27859-add_enable_search_result_marc_export_sysprefs.pl OK installer/data/mysql/mandatory/sysprefs.sql FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt FAIL filters wrong_html_filter at line 325 ( <li><a href="/cgi-bin/koha/catalogue/search.pl?count=[% results_per_page | uri %]&export=1&export_format=[% id %][% PROCESS sort_search_query %]">[% custom_export_formats.$id.name | html %]</a></li>) missing_filter at line 325 ( <li><a href="/cgi-bin/koha/catalogue/search.pl?count=[% results_per_page | uri %]&export=1&export_format=[% id %][% PROCESS sort_search_query %]">[% custom_export_formats.$id.name | html %]</a></li>) missing_filter at line 360 ( <div class="dialog message">[% export_message %]</div>) missing_filter at line 363 ( <div class="dialog error">[% export_error %]</div>) FAIL t/db_dependent/Koha/SearchEngine/Elasticsearch.t FAIL spelling indentical ==> identical indentical ==> identical 2) Translatability This will not be translatable and should be moved to templates, also the other places where export_links_html is set. HTML should not be generated in .pl files: + $export_links_html = $links_count > 1 ? + "<p>Some records exceeded the maximum size supported by ISO2709 and was exported as MARCXML instead.</p>" . $export_links_html : $export_links_html; Also here: $message = "<p>The export finished successfully:</p>" 3) System preferences I am a little in doubt about SearchResultMARCExportFromAddress. The from address can not always be set to be a library specific email, especially for installations hosted centrally by a support provider. We usually tend to use the reply-to for individual settings. But it should for sure be type = email in the .prefs file (activates validation). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/