https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847
Joonas Kylmälä <joonas.kylm...@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139628|0 |1 is obsolete| | Attachment #139629|0 |1 is obsolete| | Attachment #139630|0 |1 is obsolete| | Attachment #139631|0 |1 is obsolete| | Attachment #139632|0 |1 is obsolete| | Attachment #139633|0 |1 is obsolete| | Attachment #139634|0 |1 is obsolete| | Attachment #139635|0 |1 is obsolete| | --- Comment #45 from Joonas Kylmälä <joonas.kylm...@iki.fi> --- Created attachment 139915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139915&action=edit Bug 30847: Cleanup calculation of holds and rank Currently we loop over all the holds on the record to get a count of the reserves not waiting and a rank for the upcoming hold We can simply count the number of nont waiting holds and add 1 Note: Before this patch the count of holds included the new hold we were going to place which meant rank and count were the same. I believe countaing existing holds and our upcoming rank is the correct behavior To test: 1 - Set OPACShowHoldQueueDetails system preference to 'Show holds and their priorty level' 2 - Place a few holds on a bib on the staff side 3 - Mark 1 waiting 4 - Attempt to place hold on the bib on the opac 5 - Note 'Your priority' and 'Number of holds' are the same number 6 - Place another hold, confirm both increase 7 - Set another hold waiting, confirm both decrease 8 - Apply patch 9 - Confirm 'Your priority' is now 1 greater than Number of holds 10 - Place a hold, set a hold waiting, confirm numbers adjust as appropriate Signed-off-by: Owen Leonard <oleon...@myacpl.org> Rebased-by: Victor Grousset/tuxayo <vic...@tuxayo.net> Signed-off-by: Joonas Kylmälä <joonas.kylm...@iki.fi> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/