https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
--- Comment #312 from Blou <philippe.blo...@inlibro.com> --- You can see comment 12 from Mehdi, for some summary. There was also emails sent to the lists at the time, describing the plan. And replies that basically shut it down. It started with the calendar doing its calculation by adding one to every date object and creating a new one. A very painful way to calculate things, if you ask me. Then we also didn't like the fact that past dates were lost to modifications into the calendar. You modify a holiday for the future, and it screw your calculation in the past. So instead of having "patterns" for opening and closing, we have a discrete entry for each date. By preserving it (as long as needed), past calculation are always correct. We also added opening and close time. And we redid the UI to allow for an easier management of all that. It's pretty easy to manipulate the calendar how we want when each date can be modified individually. And we added some logic to spot the recurring pattern and create the new dates with most likely values, including unique dates like Easter, national holiday, etc... Of course, since they are unique dates in the calendar, they can be adjusted as needed, easily, a long time ahead. We've been using it for 6 years now. It requires some maintenance to follow the master, but it's worth it. Regarding the patches: we did split as asked, then, and we also invested to go Schema instead of SQL, and tried to please everyone. At some point it was just not worth it considering the low likelyhood of moving ahead relative to the effort to follow. So that's it. I already ask our dev to not switch it back to Need Signoff after the next adjustment. We'll figure out something so that our automated tool pick up when the patch doesn't apply anymore. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/