https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- This looks pretty good and happy to see this tackled, but I have some comments: 1) This copies an old mistake we made in the beginning by using $a and $t for the title search. This often won't work. We need to split these up ti=t and au=a, like we have done now for 773 and should also correct in other templates: <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of select="str:encode-uri(translate($f787, '()', ''), true())"/></xsl:attribute> 2) We should add this to OPAC and staff interface at the same time. 3) 580 is an issue. a) There can be mulitple 580 and you only display the first. b) It might belong to a totally different 7xx linking field, creating a false display. https://www.loc.gov/marc/bibliographic/bd580.html Description of the complex relationship between the item described in the record and other items that cannot be adequately generated from the linking entry fields 760-787. I am not sure how this is supposed to be done... show only if it actually directly preceeds the first 787 we are looking at here? (is this even possible?) Show the 580 separately? Leave it off for now and deal with it later? 3) I believe there was some change to the separators between fields in OPAC at least sometime ago, or maybe it got stuck? I was not able to find the bug :( I know in our records there are often a lot of 787 so we changed it to a list with separate lines for each entry. A class for the separator would help a lot here. In patch: + <xsl:choose> + <xsl:when test="position()=last()"></xsl:when> + <xsl:otherwise><xsl:text>; </xsl:text></xsl:otherwise> + </xsl:choose> In other instances in the XSLT file: <xsl:if test="position() != last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/