http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710
David Cook <dc...@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |dc...@prosentient.com.au --- Comment #34 from David Cook <dc...@prosentient.com.au> --- I really like the idea of this patch, but it still has quite a few issues. 1) This patch doesn't apply to the staff client, so library staff are still restricted to 1 hold per patron per record, even with the new system preference set to 3. 2) This patch does apply to the OPAC. You are able to place holds (as the patron) on 3 items in a record when you have the system preference set to 3. However, when you try to place a 4th hold, the error message that appears is: "Sorry, none of these items can be placed on hold." "Title / by Author. This title cannot be requested." That error message doesn't really reflect the actual situation. While I think the first message is accurate, I think the second one should say "You have exceeded the maximum number of holds (3) for this record." or something along those lines. -- Stylistically, I think the Javascript warning on the staff client when exceeding the maximum number of holds could be improved. Currently, it is: "This patron has already placed the maximum number of holds for this record Please cancel a previous hold first" These two sentences should have periods at the end and be separated with another new line. -- >From a purely functional level, it seems like you're nearly there though! I'll be excited to see this one come through :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/