https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- 1) There is a fail in the QA scripts: FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column categories.canplaceill is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Category.pm), see the SQL12 coding guideline 2) Behavior in staff interface I think, we should not use the staff person's patron category for the check on the 'new request' button in the staff interface. If a staff user has permissions for the interlibrary loans module, they should be able to place ILL requests for the users of the library. They are usually not placing ILL requests for themselves, but for others. Similar to hold requests. The check on the category should be implemented in the patron search/the user they try to place the request for. But I am not sure if this would have to be done in the backends then? 3) Changed behaviour for existing installations As all categories are allowed to place ILL requests now, we should set "Can place ILL requests?" to yes for all categories if the ILLModule is activated. This way we won't break things for libraries and they can implement the new feature if they chose to do so. But overall this looks quite good already! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/