http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458
--- Comment #24 from Jared Camins-Esakov <jcam...@cpbibliography.com> --- Comment on attachment 15675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15675 Bug 9458 - Add sorting to lists - QA Followup Review of attachment 15675: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9458&attachment=15675) ----------------------------------------------------------------- ::: C4/VirtualShelves/Page.pm @@ +249,4 @@ > my $items; > my $tag_quantity; > my $sortfield = ( $sorton ? $sorton : 'title' ); > + $sortfield = $query->param('sort') || $sortfield || 'title'; > ## Passed in sorting overrides default sorting I am a little bit perplexed by this line. Why did you add the || 'title' when $sortfield has already been set? Or, equivalently, why did you set $sortfield previously? I would have thought the simplest way to get the desired results would be: my $sortfield = $query->param('sort') || $sorton || 'title'; My chief concern is, is there some sort of side-effect in the code that you're trying to work around with this? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/