http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451
M. de Rooy <m.de.r...@rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #10 from M. de Rooy <m.de.r...@rijksmuseum.nl> ---
QA Comment:
This is a hard one. Also taking into account the comments of Liz and Jonathan.
I do appreciate your finding a solution in this minefield :)
When taking some distance from Koha and just looking at the code, the
introduction of the reserve id parameter in ModReserve seems not to be a good
idea. It is somewhat 'unusual' way of resolving a problem. (Please note that I
understand that we are editing not-so-ideal code already..) It will not make
the code more readable/maintainable(..)
When going back to Koha, I also think that we should resolve the problem at
another place. That is the checkin should not display two prompts (probably one
adjusted prompt for this situation).
When the book is checked in at the transfer branch, the transfer should be
marked as arrived and at the same time the transit hold should become a waiting
hold. Actually, AddReturn calls ModReserveStatus but it will update a book with
priority 0 only for found="" and not for found=T. Could we resolve it there?
About Liz' comment: If we want to know where the transfer was generated, we
should probably add some additional field to branchtransfers. At this moment we
just do not know how it was generated.
So my (somewhat intuitive) recommendation would be not to push this patch in
this state. I just 'arbitrarily' picked Failed QA for now. But feel free to put
it in Discussion and raise a discussion on the dev list. I will send a short
mail to other QA team members.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
