https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166
Nick Clemens <n...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |n...@bywatersolutions.com
Status|Signed Off |Failed QA
--- Comment #11 from Nick Clemens <n...@bywatersolutions.com> ---
This looks neat, I like the feature, the patches need some cleanup
Must fix:
- the patch adds the function _add_rowdata, I think it's a rebase leftover?
- the call from _handle_one_result should be updated to pass the biblio related
preference to the updated routine
- delete the commented lines from the code
Could fix:
- the routine should take a hashref, the more parameters we have, the nicer it
i s to have them named
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
