https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

Jonathan Druart <jonathan.druart+k...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha@gmail.
                   |                            |com

--- Comment #44 from Jonathan Druart <jonathan.druart+k...@gmail.com> ---
1.
+    return { status => '' } unless $borrowernumber;

+    return 0 unless $patron;

No, you can raise an exception if you want.

2. There is no explanation on the logic changes. Can you detail?

3. Code is duplicated in controller scripts, that feels wrong. We certainly
want it in a module, covered by tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to