https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092
--- Comment #16 from David Gustafsson <glask...@gmail.com> --- (In reply to Emily Lamancusa from comment #15) > It sounds like you're looking for something more rigorous, but I can provide > a little more info on the results I got when testing for sign-off, if that's > helpful: > > For my testing, I used the "add multiple copies" feature to create a bib > with 400 items split between 4 branches. I then timed the page loads for > placing a hold a few times on master and a few times with the patch (nothing > fancy, just literally used a stopwatch timer). I got page loads taking about > 18-23 seconds on master, and 9-11 seconds with the patch. > > As I said, not statistically rigorous, but definitely noticeable. That's great :) I didn't know about that feature, very useful for testing this and similar patches. I think testing the way you did is completely sufficient, but will also attach to flame graphs so can see what parts of the code is sped up. Basically, without the patch 44.3s is spent in Koha::CirculationRules::get_effective_rule, with the patch that time is reduced to 49.9ms (for this particular benchmark using about 1400 items). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
