http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575
Jonathan Druart <jonathan.dru...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.dru...@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.dru...@biblibre.com> --- QA comment: Why do you modify 2 routines when you can just modify the pl file? To me, Getbranches($foo, $branch) is not consistent. I think you can do something like if ( C4::Context->preference('IndependantBranches') ) { $reserve{'branchloop'} = GetBranchDetail($res->{'branchcode'}); } else { $reserve{'branchloop'} = GetBranchesLoop($res->{'branchcode'}); } Feel free to discuss if you disagree :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/