https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462
Jonathan Druart <jonathan.druart+k...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #18 from Jonathan Druart <jonathan.druart+k...@gmail.com> --- 1. Please run the QA script and fix the warning (tidy) 2. The manual changes (is_boolean) added to the schema file must be in a separate commit, or it will get lost when pushed 3. indentation is 4 spaces, not 2 (see changes in categories.tt) 4. Could this be achieve without adding a new column (needs_password_reset) but instead compare dateenrolled and password_expiration_date? If there are the same, then we display "It's your first login", otherwise "Your password has expired". Am I missing something? 5. Not sure how this can behave properly with third-party using the REST API to create patrons (for discussion only). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/