http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215
Jonathan Druart <jonathan.dru...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #97 from Jonathan Druart <jonathan.dru...@biblibre.com> --- QA comment: I didn't find any bugs, all looks good on a functional point of view. However, I found some issues regarding the code. 1/ QA tools complains, I will submit a followup for that. 2/ course.tt : I think the TODO could be removed 3/ the exported variable $VERSION is useless in C4::CourseReserves 4/ It would be better to used hashref instead of hash for some routines in C4::CourseReserves 5/ In C4::CourseReserves, @FIELDS would be returned by a routine (instead of using a global var). 6/ Some use of the loop var ($_) 7/ I am not sure about the consistence of changes in C4::Items::GetItemTypes To specify the type of the return in parameter is quite weird. 8/ 3 pl scripts should show an error for the user in the template if no course_id exist instead of dying. 9/ Is it normal there is no flag required for course_reserves/course-reserves.pl ? 10/ In kohastructure: Why do you add constraints using an alter table command? Constraints should be added with the CREATE TABLE command 11/ ShowCourseReserves could be easily calculated in .pl file 12/ YUI buttons should be replaced with Bootstrap 13/ What is the use of the class "noEnterSubmit" (in template files)? I didn't find any reference in .js or .css files. 14/ Template names is now .tt, not .tmpl Please detail 9 and 13. Marked as Failed QA for 8, 10 and 12. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/