https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
--- Comment #6 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- Created attachment 159824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159824&action=edit Bug 35536: Remove Method->delete and reorder rollbacks We removed the need for Method->delete, so we can remove that. Also we should now move all RemovePlugins calls BEFORE the last rollback. Nice and clean :) Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Install a plugin before following test plan. You could use the attached 'DONT PUSH' example patch. Having 3 recs in data and 45 in methods with that plugin only (before/after tests). Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/