https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #19 from Jonathan Druart <jonathan.druart+k...@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #18) > So it's almost done. Questions: > 1. What is DT_delay for? We want to make sure the AJAX request is there. In some cases (see bug 35284), the wait_for_ajax was called but the AJAX request was not triggered yet, so we didn't wait for it to finished. > 2. I only though of it just now: instead of having the flag > window._pageFullyReady, should the problematic buttons be hidden in the > HTML? (and maybe have a dummy button with a loading icon in place to show > the user that stuff it loading) And then the stuff in $(document).ready() > makes them visible after setting the onclick callback. And the test just > waits for the button to be visible instead of the flag to be set. We should not need more than wait_for_ajax here IMO. If it takes more than 10 sec then there is something wrong somewhere else. We could extend the delay specifically for this call. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/