https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959

Victor Grousset/tuxayo <vic...@tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #17 from Victor Grousset/tuxayo <vic...@tuxayo.net> ---
I didn't notice bug 28869 has this one as dependency. So I was applying these
patches on top of 28869 + these patches. So of course it conflicts.
So no conflicts when applied properly, back to NSO.

1st patch test plan with both patchsets applied: ok

2nd test plan:
> Run qa tools on patch set that touches one of the modules.
> (I used 28869 touching AuthorisedValue.pm.)

I don't know what the test plan expects here, is that ok?:

 FAIL   Koha/AuthorisedValue.pm
   FAIL   valid
                Constant subroutine Koha::AuthorisedValue::NUM_PATTERN
redefined
                Constant subroutine Koha::AuthorisedValue::NUM_PATTERN_JS
redefined

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to