https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869
--- Comment #21 from Pedro Amorim <pedro.amo...@ptfs-europe.com> --- (In reply to Esther Melander from comment #19) > The test plan works through step 11 and an item is created. The item created > defaulted to the 952$y item type Book, even though only the 952$a is in the > action. That may not always be the correct item type, though it is probably > better for something to be assigned than nothing. Good catch. Thanks. I took a deeper look and I'm convinced this is because of the following code in Item.pm sub store: unless ( $self->itype ) { $self->itype($self->biblio->biblioitem->itemtype); } The item will default to the itemtype at the biblio level if not mapping for itype is exists. In the case of this test plan, biblio 79 field 942$c is 'BK' so the code is grabbing that when storing the item. This follows core logic as the patch is using a core method AddItemFromMarc. I think this is a good behavior for this use case. Let me know if you disagree! > The test plan implies the 952$a is required to create an item, but I was > able to create an item with only the 952$8. Interesting! I'm sure I was unable to create an item without 952$a before but I've tried now and, as you say, the item is created regardless of 952$a mapping existing or not. I had different approaches for this solution before the current patch, using different methods, so this is likely a remnant of that i.e. with a previous version of the patch this was the case, but not anymore it seems. (In reply to Andrew Fuerste-Henry from comment #20) > If we were creating items from a 952 while importing a new bib, which item > fields, if any, would be required? It makes sense to me to have this process > match those requirements. This does make sense, I agree. Are you referring to bulkmarcimport.pl or a different method? Can you please provide a test plan on creating items from a 952 while importing a new bib? If so, I'll have a go at testing that myself. Thanks! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/