https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164
David Cook <dc...@prosentient.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #13 from David Cook <dc...@prosentient.com.au> ---
There's a few things here:
1. We do need the referrer for the staff interface too, since people might be
using bookmarks, have expired sessions when clicking on an old search result,
manually going to a URL written by hand, etc.
2. The session variable is different between the googleopenidconnect and the
REST client. I think it'd be best to use the same meaningful name. (I also
think referer as used in the REST client is too generic. That could cause
problems down the line if we started tracking refer for other reasons. I think
the one you used for googleopenidconnect could work (ie "auth-refer-uri"), so I
think just harmonize those.
3. It would make more sense to validate the referrer input before setting it as
a session variable.
4. Instead of "if (defined $referrer_url) && ($referrer_url ne '')", I think we
could just do (if $referrer_url) in Perl. This syntax reminds me more of
Python/Ruby.
--
Overall, it's looking good, and I'm really looking forward to having this
feature in Koha.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
