https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237
--- Comment #25 from Martin Renvoize <martin.renvo...@ptfs-europe.com> --- Right.. we can drop the TMP fix patch once those have been corrected upstream in main. I also think the Restore final fallback isn't really required but I did it whilst I was in here as Jonathan mentioned it. The final patch is the important one as it brings us a step closer to the end goal by getting the tests working without having to manually install a translation. However, I'm now strongly of the opinion we should not be doing the interface level check and instead use the highest priority language in the system preferences as the 'default'. My understanding of how 'default' is used is that the 'default' notice is generally written in the primary language of the system and so it would match the top pick for interface language selection and possible not match the selected interface language of the moment. Use cases: 1) US English only. Default == English + Includes should be English 2) Single translation only (French Canadian). Default == French Canadian + Includes should also be French Canadian. 3) Multiple languages. Default template written in French Canadian, the Include should also use French Canadian (even if the staff user clicking to print has switched to Italian) otherwise we have the main notice in French Candian with the Include parts in Itelian. Right now. case 3 fails. I also think we could re-arrange the tests a bit to clean up.. I think we could/should be testing Template selection _+ include selection in the same places.. i.e each time we check the 'title' we would also check the 'content' to ensure they match consistently.. rather than the current check of template selection followed by a section for include selection checking. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
