https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Victor Grousset/tuxayo <vic...@tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #165112|0                           |1
        is obsolete|                            |

--- Comment #98 from Victor Grousset/tuxayo <vic...@tuxayo.net> ---
Created attachment 165443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165443&action=edit
Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved

The rule "opacitemholds" seemed not to be controlled in some cases.
This patch adds a control for this issuingrule in such a way it is checked
across all interfaces (staff, opac, api).
Added error message when trying to hold on the record and opacitemhold
is set to "Force" to item-level hold

What this patch does :
-- Move get_opacitemholds_policy check into Reserves.pm::CanBookBeReserved
-- Update CanItemBeReserved to return recordHoldsOnly status if interface is
OPAC
-- Update warning labels in opac-reserve.tt accordingly.

To test:
0 - Apply patches
1 - Set rule to "Don't allow" item specific holds on opac
2 - Attempt to place item-level hold on staff interface
3 - Hold is still allowed (rule do not apply to staff)
4 - Attempt to place item-level hold from opac or ilsdi
5 - Hold is not allowed (rule apply from opac or ilsdi)
6 - Change rule to 'force'
7 - Item-level hold can still be placed from the staff interface
8 - Record-level hold cannot be placed from opac or ilsdi

Signed-off-by: Victor Grousset/tuxayo <vic...@tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to