https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628
--- Comment #74 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> ---
Going to pass QA with some remarks (no blockers for me):
FAIL installer/data/mysql/atomicupdate/bug_35628.pl
FAIL file permissions
File must have the exec flag
WARN tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 11)
WARN t/db_dependent/api/v1/ticket_updates.t
WARN tidiness
The file is less tidy than before (bad/messy lines before: 57,
now: 58)
COMPARE
+ status:
+ type:
+ - string
+ - "null"
+ description: Current status of the ticket
+ readOnly: true
WITH
+ status:
+ type:
+ - string
+ - "null"
+ description: Status of the ticket after this update
=> The first is readonly, the second is not. Just noting.
+ # Update ticket status if needed
+ if ( $ticket_update->{status} ) {
+ my $ticket = $update->ticket;
+ $ticket->set( { status => $ticket_update->{status} } )->store;
+ }
Reading this the first time without deeper knowledge of the feature, these are
quite confusing variable names. $update ?
js
if (o["!="] === '[% st.authorised_value | html %]') {
additional_filters.status.push({ '!=': "[% st.authorised_value | html %]" });
No blocker. But using != here like this creates obscure code.
General:
Lots of patches here have no specific test plan.
When I want to add a concern, it is hard to find how to. Not intuitive. Under
the Concerns tab I should be able to add a new one.. (It is under New menu.)
Updating status with custom ones is confusing. Display of the custom status on
Ticket update looks suboptimal. If it is the intention to change the main
status, the feature does not work as expected?
Please improve on new follow-up reports?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
