https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271
--- Comment #24 from Thibaud Guillot <thibaud.guil...@biblibre.com> ---
(In reply to David Nind from comment #22)
> The patches now apply, however there is an error when restarting everything
> - see [1]. I think I managed tow ork around this, but what I did may be
> incorrect.
>
> I tested using koha-testing-docker (KTD).
>
> I have changed the status to Failed QA:
>
> 1. Have set the rules as per the test plan.
>
> 2. I can make one booking, then when I go to make another for the same
> patron, I get a failure error (as expected, as Bookings per item (total) =
> 1).
>
> 3. I changed the rules so that they are 2, 2, and 2 - with the expectation
> that the same patron could make 2 bookings for the item, at different times.
> I get "Failure" in a red box at the top of the dialogue box if I try to make
> two bookings.
>
> 4. I have not changed any other settings, or made any changes to the item
> type:
> . Under the items section for the record where you change it to bookable
> it says "Item type bookable: No"
> . I don't know whether that causes an issue or not
> . If you go to change the bookable setting, then if the item type says it
> isn't bookable, then you shouldn't be able to override and make an
> individual item bookable(?) Not sure if this is the way it should work, or I
> have misunderstood.
> . Probably not really understanding what the interactions should be here:
> . Set as bookable at the item type level, override at the individual
> record/item level?
> . Set as bookable at the item type level only? Then having bookable
> showing at the individual record/item level doesn't make sense to me.
> . Maybe some more explanation is required in the commit message and test
> plan of the intent may help
> . (I haven't read through the bug, and related bugs, history)
>
> 5. I'm not a fan of generic "Failure" messages. If there are a set of rules
> (as in this case), then I think any error message should indicate the reason
> for the failure so you can correct things. In this case, I don't know what
> the reason for the failure is.
>
> [1] Error when restarting everything
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> After the patch is applied, I get this error message when restarting
> everything (apply patch, updatedatabase, flush_memcached, restart_all):
>
> restart_all
> Restarting Apache httpd web server: apache2.
> Restarting Koha ILS: koha-commonStopping Plack daemon for kohadev:.
> Stopping Z39.50/SRU daemon for kohadev:.
> Stopping Koha worker daemon for kohadev (default):.
> Stopping Koha worker daemon for kohadev (long_tasks):.
> Stopping Koha indexing daemon for kohadev:.
> Successfully stopped all services for instance koha-common:.
> Starting Plack daemon for kohadev:.
> Starting Z39.50/SRU daemon for kohadev:syntax error at
> /kohadevbox/koha/Koha/Booking.pm line 118, near "if if"
> Compilation failed in require at /kohadevbox/koha/Koha/Bookings.pm line 23.
> BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Bookings.pm line
> 23.
> Compilation failed in require at /kohadevbox/koha/Koha/Biblio.pm line 46.
> BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Biblio.pm line 46.
> Compilation failed in require at /kohadevbox/koha/Koha/Biblios.pm line 25.
> BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Biblios.pm line
> 25.
> Compilation failed in require at /kohadevbox/koha/Koha/Libraries.pm line 25.
> BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Libraries.pm line
> 25.
> Compilation failed in require at
> /kohadevbox/koha/Koha/Object/Limit/Library.pm line 22.
> BEGIN failed--compilation aborted at
> /kohadevbox/koha/Koha/Object/Limit/Library.pm line 22.
> Compilation failed in require at /kohadevbox/koha/Koha/AuthorisedValue.pm
> line 26.
> BEGIN failed--compilation aborted at
> /kohadevbox/koha/Koha/AuthorisedValue.pm line 26.
> Compilation failed in require at /kohadevbox/koha/Koha/AuthorisedValues.pm
> line 25.
> BEGIN failed--compilation aborted at
> /kohadevbox/koha/Koha/AuthorisedValues.pm line 25.
> Compilation failed in require at /kohadevbox/koha/C4/Koha.pm line 27.
> BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Koha.pm line 27.
> Compilation failed in require at /kohadevbox/koha/C4/Biblio.pm line 88.
> BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Biblio.pm line 88.
> Compilation failed in require at /kohadevbox/koha/Koha/Z3950Responder.pm
> line 22.
> BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Z3950Responder.pm
> line 22.
> Compilation failed in require at /kohadevbox/koha/misc/z3950_responder.pl
> line 27.
> BEGIN failed--compilation aborted at
> /kohadevbox/koha/misc/z3950_responder.pl line 27.
> failed!
> Starting Koha worker daemon for kohadev (default):.
> Starting Koha worker daemon for kohadev (long_tasks):.
> Starting Koha indexing daemon for kohadev:.
>
> At line 118 of Koha/Booking.pm there is an "if if" - if I remove one of the
> ifs, then everything restarts properly.
Hello David,
Thanks for your feedback. I remove the typo issue ("if if") and rebase my
commit into one unique commit by the way.
For the failure message its the original behavior when errors comes but not
necessary from circulation rules. I'll look into the details of why it's
happening
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
