https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37056
--- Comment #6 from David Cook <dc...@prosentient.com.au> --- Comment on attachment 167617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167617 Bug 37056: Mount a new intranet_svc api to avoid redirects Review of attachment 167617: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37056&attachment=167617) ----------------------------------------------------------------- I think overall this is probably the way to go in order to get proper API responses. Going to Fail QA for now because of an unnecessary change and an incorrect path for the prod app root. ::: debian/templates/plack.psgi @@ +56,5 @@ > root => $ENV{DEV_INSTALL}? $home: "$home/intranet/cgi-bin" > )->to_app; > > +my $intranet_svc = Plack::App::CGIBin->new( > + root => $ENV{DEV_INSTALL}? "$home/svc": "$home/svc/cgi-bin" That prod path looks wrong. I think it would need to be $home/intranet/cgi-bin/svc. @@ +121,4 @@ > enable "+Koha::Middleware::CSRF"; > $intranet; > }; > + mount '/intranet_svc' => builder { I'm a bit concerned about the impact of mounting another PSGI application, although I don't have any numbers to support that concern at the moment. That said, I've proposed the same thing in bug 31380 and friends. There could be merit to this as well, since it is an API so we wouldn't want the normal HTML exception handling... ::: errors/403.pl @@ +33,4 @@ > authnotrequired => 1, > } > ); > +$template->param( This change looks unnecessary. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
