https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28924
Nick Clemens (kidclamp) <n...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
CC| |n...@bywatersolutions.com
--- Comment #29 from Nick Clemens (kidclamp) <n...@bywatersolutions.com> ---
Patch doesn't apply, please rebase
From reading the code:
is_patron_inside_charge_limits checks for no issues charge limits like
category/pref/defaults to 0
then you test if the charges are defined - but they always will be, because
default 0
CanBookBeIssued then also checks if they look like a number, and they always
will because defaulted to 0 - before these patches leaving the pref blank means
it isn't active (except noissuescharge) I will attach a test I think will fail
after applying, check if I am right there.
The two new routines in Patron.pm both take borrower arguments - is there a
reason not to simply use 'self'?
circ/circulation.pl line 590
You add 'noissues=>1' without checking the fines override pref - is this
correct?
The new GetPatronCharges routine in the Categories template plugin seems
misplaced - I think we should be using your new routines directly from the
patron object in the templates - it looks like there are other variables
related to charges in the scripts - so we should try to avoid double work here
and pass more info forward if we have already fetched it.
I don't think the tests are covering all cases and should be expanded a bit.
This is just a quick pass, so let me know if anything needs clarification
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
