https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

--- Comment #4 from Martin Renvoize <martin.renvo...@ptfs-europe.com> ---
I'm looking to come back to this now.

OK, so you'd like me to update the existing endpoint to
`/circulation_rules/kinds` and add mine as `/circulation_rules`. I can do
that.. though do we know if anyone out there is using the /kinds route already?

I did think about the order of parameters, though I not wed to it.  I had them
as path params as I felt it made it clearer that the endpoint expects all of
them to be filled.. however we could just have them as query params and then
order is inherently meaningless and in fact we don't actually always needs all
of them really.

Yes, I said the return structure is underspecified.. but it's also a bit
variable.. I'll try to see what I can come up with.

Are you saying you want the 'kinds' param to be an enum of all rule kinds..  I
was sort of trying to avoid having to list those again..  I wish it was simple
to build this particular list from code to embed into the spec.. maybe I can..
I'll investigate.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to