https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363
--- Comment #20 from Kyle M Hall <k...@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #19) > Some small stuff, please follow-up: > > 1) Database update > > It's not using say_success, but it's also not giving us any success message > :) Done > > 2) What is actually meant by "manage"? > > I assume that "manage" actually means "edit". While any of the permissions > allow to "view". > > If that is the case, I feel it would be good to adjust the permission > descriptions accordingly. That was the pre-existing term and in Koha we've always used it as a catch-all for anything not covered by more specific permissions. It covers more than just viewing, such as approvals. > There is a slight discrepancy tho: > With only create permission, I have the entry to suggestions in the "more" > menu, but it's missing from the navigation in the acquisition module. Can you add a screenshot or be more specific about where this pulldown is? > I can also not see the pending suggestions on the start page. That is intended. A librarian that can only create suggestions has no need to see the suggestions that need managed. > I think we should adjust the navigation in the acq module at least. > > Should the pending suggestions on acq and staff interface home page be > visible with manage_suggestions only or also with any suggestion permission? They should be visible only for manage_suggestions. > > 3) Question > > + <div class="note">Only staff with superlibrarian or full > suggestions permissions are returned in the search results</div> > > I think this is in line with the previous behavior, but I wonder if we > should not change to allow "any" instead of "full" here. I disagree. This is still a limit for just librarians that manage permissions, just like all the other manage permissions we can limit patron searches too. > > I assume this is for setting the manager of a suggestion - editing might be > required, but not sure if delete and create would be as well. They would not be. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
