http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252
--- Comment #11 from Paul Poulain <paul.poul...@biblibre.com> --- hi Mathieu, Trying to investigate this patch, because it's a useful improvement I haven't tested it yet, but i'm QAing first. (disclaimer : when I say "MARC21", I mean MARC21 and NORMAC, that are very close) I find some strange things: * Country of publication + 'Country-publication', => you add this entry, just for UNIMARC. Isn't it relevant for MARC21 ? The LoC use Country-publication for 1053, so your choice is OK (http://www.loc.gov/z3950/agency/defns/bib1.html) * in MARC21, there's a use of Date/time-last-modified, not Date-time-last-modified : etc/zebradb/marc_defs/normarc/biblios/record.abs:# NiN melm 005 Date/time-last-modified etc/zebradb/marc_defs/marc21/biblios/record.abs:melm 005 Date/time-last-modified etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml: <!--record.abs line 44: melm 005 Date/time-last-modified--> etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml: <target_index>Date/time-last-modified:w</target_index> etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl: <z:index name="Date/time-last-modified:w"> => WHY this change ? * music publisher: you change -att 51 Number-music-publisher +att 51 Music-number but number-music-publisher is used by MARC21, so why do you remove it ? I think we could/should use Identifier-publisher-for-music everywhere, as it's bib1 attribute name for LoC (http://www.loc.gov/z3950/agency/bib1.html) I have no other comments, except a general one = it would have been much easier to test this patch if it had been splitted in smaller ones. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/