https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37522
--- Comment #4 from Janusz Kaczmarek <[email protected]> --- (In reply to Katrin Fischer from comment #3) > Hi, can you please detail how it works/should work (before/after)? Now: 1) log records previous version of modified biblio record (very useful); 2) log records current version of modified item record (which is inconsistent with biblio behavior; not useful, since we have the current version in the database; leading to data loss in case of the first modif: the initial values go to /dev/null--which is most frustrating when working with the logs). Also note that the librarian sees the changes both of the biblio record and item record in one single table, but the meaning of the rows is opposite. It is my strong conviction that is should be consistent (the inconsistency here is not understandable for the librarians) and that it is probably buggy, maybe from the very beginning (the initial value of the item is never recorded in the log). > If I understand correctly it changes from logging the new version to logging > the old version. Yes--for items. > I think this would be a behavior change for libraries working with the logs > and it would not be "visible" when the change occurred in the logs. Yes, it changes the behavior for better, IMHO, by eliminating the (most probably buggy) inconsistency. > We discussed at one of the last meetings a new coding guideline that new log > entries should be using the new JSON diff. Could you have a look please? > > https://wiki.koha-community.org/wiki/Coding_Guidelines#ACTN1: > _New_additions_to_actions_logs_should_use_the_JSON_Diff_format The proposed patch make use of the diff feature: after applying it action_logs.diff column is filled as well, according to the proposal (but not visible from the interface). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
