https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36217
--- Comment #16 from David Cook <[email protected]> --- (In reply to Jonathan Druart from comment #15) > I don't have time at the moment to review this, but it feels like adding a > new 'only_last_hour' flag server-side is wrong. It's much better for the status quo. If we did want to make the time adjustable (so not just the last hour) then it would be wrong/bad. But for now I think it makes a lot of sense, as it is easy to understand/maintain and reduces complexity. > The previous way was more flexible. Why didn't it work? I have not found the > reason in the comments. If I recall correctly, it's because the client/browser sent the string in UTC, and the API server processed it according to the server local time zone or the DB's local time zone. So on koha-testing-docker, it would work because it uses UTC for the local time zone. But for most servers in the real world it wouldn't work because they used their own local time. Of course, an alternative fix would've been to just treat the incoming timestamp as UTC and then convert it, but datetime math can be complicated. That would've been a more flexible solution, but also a more complicated one. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
