http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739
--- Comment #53 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Comment on attachment 18041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18041 [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Review of attachment 18041: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6739&attachment=18041) ----------------------------------------------------------------- Hi Chris H. and Kyle, I have taken a look at those patches and found some problems, the most severe is in the database update (see splinter review comments below). Please fix and resubmit. And a little note for a possible enhancement: The new option doesn't show up on the patron categories summary table in administration. ::: installer/data/mysql/kohastructure.sql @@ +441,4 @@ > `reservefee` decimal(28,6) default NULL, -- cost to place holds > `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown > to this category (1 for yes, 0 for no) > `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron > (Adult, Child, Professional, Organizational, Statistical, Staff) > + `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- > wheither or not a patron of this categori can renew books or place holds once > their card has expired. 0 means they can, 1 means they cannot, -1 means use > syspref BLockExpiredPAtronOpacACtions Tiny typo: categori ::: installer/data/mysql/updatedatabase.pl @@ +6845,5 @@ > + NULL, > + 'YesNo' > + ) > + "); > + $dbh->do("ALTER TABLE `categories` ADD COLUMN > `BlockExpiredPatronOpacActions` TINYINT(1) DEFAULT 0 NOT NULL"); The default value for new patron categories is -1 (use system preference), but for existing installations we create the column with default 0. I checked that the follow ups are not fixing this. Failing QA. Also: It would be a bit safer to make sure the column is added after category_type like in kohastructure.sql. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/