https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Status|Passed QA |Failed QA --- Comment #13 from Katrin Fischer <[email protected]> --- Some hopefully smaller stuff here: 1) This patch introduces a new notice category: Lists. I think this is a good idea, but right now this will only contain one notice, wihle the other list related ones are still under OPAC, creating an inconsistency. I see 2 options: * Add the new category on a separate bug and then move all the notices into it at the same time * Move them here, notices are: LIST, SHARE_INVITE, SHARE_ACCEPT 2) The big question: add notice on update or not. I just pushed another bug recently that decided to not add on update. I think we could probably argue for both. But maybe we should try to have some guideline/consistency here? Bug 36915 - Send email notification when a booking is cancelled Don't add on update * Least surprise, no behavior change * Libraries will not miss to translate/adapt the notice text to local guidelines Add on update * Libraries can see how the notice looks like. But: bug 36815 will help with that now. I am leaning towards removing the database update right now. But happy to discus and be persuaded. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
