https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659
--- Comment #89 from Victor Grousset/tuxayo <[email protected]> --- > Is this test meant to be run after the atomic update > file is integrated (and thus, deleted)? It's meant to be ran by the CI to detect a dbrev that wasn't integrated by the RM or RMaint. So it should fail if ran at this stage of the process. (and it doesn't need to be ran) No issue there then :) --------- Thanks for the coverage improvements! stmt bran cond sub total 55.6 38.1 66.6 88.8 57.1 ↓↓↓↓↓ 68.1 64.2 83.3 88.4 70.3 Harvester->init() and it's 120 lines are not covered at all. I just added $harvester->init(); in the tests and coverage went from stmt bran cond sub total 68.1 64.2 83.3 88.4 70.3 to ↓↓↓↓↓ 82.9 71.4 83.3 96.1 82.6 There might be a smarter way to test that ^^" Maybe with a return value of 1 at end we check that? So we can have regression testing of at least it not blowing up ^^ But before that, the execution falls into `if ( $response->is_error )` because I likely forgot some setup. Any idea of what would be missing to have a working run of init()? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
