https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #35 from Jonathan Druart <[email protected]> --- Patches rebased, adjusted and improved. Everything is on a remote branch: I had a go, here is a summary of the situation: 1. We need 2 flags in the table settings: one to store the "configuration" (number of entries, column visibility, etc.) of the table, and one to store the previous search. With the new patch set we now have: tables_settings.default_save_state tables_settings.default_save_state_search The existing "stateSave" occurrences shown that: * Bug 33426 ("Add client storage of user-selected DataTables configuration to suggestion.tt") => We want to keep everything (search+config) for the suggestions table * Bug 22276 ("Add client storage of user-selected DataTables configuration") => The aim of this patch was the premise of this 33484 one. We only wanted to make the selection of the column persistent. On the library list view. * On the pending and received orders page (not sure since when we have them, at least bug 20212) => We want to keep everything 2 problems here, the first one is that the the pending orders table (#pending_orders) didn't have the table settings (now done with patch "Add table settings to pending order"). The other is that the orders received table (#receivedt) does not use KohaTable or kohaTable, but DataTables directly. As there is no column visibility or filters stateSave is enable directly on this table. We should not do that anymore, this is an exception! * Bug 21852 ("Add more columns and column configuration to overdues report") We want to keep everything Those 3 tables that want "everything" to be kept have the default_save_state_search flag set to 1 in the yml config file. 2. Code is copy-pasted between columns_settings.inc and datatables.js, but at least it does not appear a 3rd time for the KohaTable vue component. Good enough for now IMO. 3. In order to fix bug 27467 with this change the last patches actually save the state all the time. So that we can copy the link for sharing purpose. 4. The state is not restored correctly when the share link is used. On complex table (patron search for instance) there is a shift with the table headers, and it get worst when columns are hidden. Not sure it is fixable. Yes the patches will be moved out of this bug report it is too hard to deal with. 5. We may want to have a syspref to turn off the whole stateSave feature (in case of performance issue? Or privacy?) Please test and provide early feedback. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
