https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37895
Emily Lamancusa (emlam) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Emily Lamancusa (emlam) <[email protected]> --- I hate to say this after the work that's gone into this, but I think we're missing some important code history here... See bug 25078 - error handling is already baked into Installer.pm, to abort the update if a dbrev fails (or allow a --force parameter to keep going anyway), and to make sure the output is displayed correctly regardless of whether the update is being run from the command line or from the web installer. Testing these patches as-is, I'm getting no output at all to the console on a bad dbrev - the update subs in Installer.pm collect all of the messages and pass them along to the console after the dbrev is finished, and exit(1) bails out of the whole script before that happens. The web installer does display the error messages, but they have added cruft with the patches - an extra layer on the stack trace, and a bunch of array references. Replacing exit(1) with a die statement works better, but die prints its own error message, so there's no real benefit to having both say_failure and die. I don't think we want to include a try/catch in the dbrevs themselves, except in cases where special error handling is actually needed. Otherwise, it's just clashing with the error handling upstream. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
