https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171978|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <[email protected]> --- Created attachment 173130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173130&action=edit Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.) Signed-off-by: Olivier V <[email protected]> Signed-off-by: Pedro Amorim <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
