https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37930
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart <[email protected]> --- 1. The code in beforeCreate needs to be adjusted. There could be a race: we should not have this.loaded() called twice. 2. functions are defined in 2 different places (store/main and store/authorised-values) 3. Other apps need to be adjusted. 4. (In reply to Matt Blenkinsop from comment #15) > Having the methods outside of mainstore involved a lot more passing data > back and forth so I've moved them back into main store and the AVs are > loaded into there. This means it is much easier to access them in the > components Could you push a branch with this version and explain exactly what was the problematic part? Moving av code to main is not ideal IMO. We are still in the discussion step here it seems, not ready for inclusion. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
