https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Signed Off |Failed QA --- Comment #169 from Jonathan Druart <[email protected]> --- Very quick code review and testing: 1. Koha::Notice::Message->patron + return unless $patron_rs; This is not tested 2. Koha::Notice::Message->template + return unless $template_rs; Same 3. QA script failures FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt FAIL tt_valid lines 75 FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/notices.tt FAIL spelling noice ==> noise, nice, notice 4. <th class="nosort"> </th> + "aoColumnDefs": [ + { 'bSortable': false, 'aTargets': [ 'nosort' ] } + ], You should use .NoSort on the th and don't need the aoColumnDefs. 5. members/notices.pl?borrowernumber=5 Without entry we should not show the table but "There are no notices for this patron" instead. 6. "Pending" notices have their checkbox disabled, we should display a onmouseover tooltip. 7. if you print a notice that was "failed", it's then "sent" but the "delivery note" failure is still displayed on the template. Does it make sense? 8. Is it expected to print using "email" mtt, shouldn't we use the "print" template instead? 9. 2 different outputs: * Using "Print" from the actions column http://localhost:8081/cgi-bin/koha/tools/print_notice.pl?message_ids=73 Using CHECKIN, all on one line "The following items have been checked out: E Street shuffle Thank you for visiting Centerville." * Using "Print" from the modal http://localhost:8081/cgi-bin/koha/members/notices.pl?borrowernumber=5 "Checkouts The following items have been checked out: E Street shuffle Thank you for visiting Centerville." Also the name of the pdf in the second example is "notices.pl.pdf" 10. "Resend" - Shouldn't we actually enqueue another message in order to keep track of what have been failed/sent? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
