http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129
M. de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #28 from M. de Rooy <m.de.r...@rijksmuseum.nl> --- (In reply to comment #20) > One nice feature of this patch as it stands is that you can specify both > MaxFine and MaxFineIsReplacementPrice at once. If the replacement price is > over the MaxFine, it will be reduced. > > To move it to the circulation matrix would require a full re-write. The > overduefinescap functions within CalcFine, rather than UpdateFine. > > Perhaps we have fines logic in too many places. Maybe MaxFines logic needs > to be moved to CalcFine as well. I agree with Galen that moving them both out of the prefs would be great. But adjusting a lot of troublesome circulation code would be great too. All together, I do no think that we should block this patch for that reason. BTW Kyle should be the ideal candidate to get the code in CalcFine and UpdateFine on a higher level as followup :) Moving the status back to Passed QA for final RM comment. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/