https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
--- Comment #46 from Katrin Fischer <[email protected]> --- > > Some things I wondered about: > > + if ( !$amount ) { > Why this added condition on the calculation? > To me it looks like that would keep fines from increasing. I had expected an > else case that keeps things like before if the new option is not used. OK, sometimes it takes a moment longer, I just realized my mistake: The if makes sense to me now. Amount is not the current fine, but what is calculated within the script as the new fine. if there is already a new fine (maxfinesday was used and calculated), we don't want to change it, but when it wasn't calculated, it should calculate the normal fine. One new question: What about CalculateFinesOnReturn? This changes how fines are calculated in fines.pl, but leaves CalcFine unchanged. So when fines in Koha are recalculated for some reason, like when using CalculateFinesOnReturn, the fine will be reduced or changed to the multipe of fine amount * fine interval eventually. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
