https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736
--- Comment #65 from Jonathan Druart <[email protected]> --- (In reply to Jonathan Druart from comment #62) > commit 025ed2d09aadc229490c94c5c82234e6942dbcf9 > Bug 33736: Ensure datatable filter row takes visible into account > > I am really concerned about this commit. > On bug 33484 AND bug 36640 I am adjusting this code to fix problems with the > column visibility. I made sure that we didn't have conflict with the state, > the column visibility, the hidden column (forced in the config), and the > different tables. > > This patch should really be on its own bug and the different tables tested, > not only this one. > > I am going to drop the changes made here for the other 2 bugs, but if we > have 4 different codes (pre 33736, post 33736, 33736+33484, post > 33736+33484+36640) to maintain in main and stable, it will be a nightmare to > fix. I have rebased bug 33484 on top of main and dropped the changes from this commit. Everything is ok on this table (as expected). If we plan to have 33484 in 24.11 and not bug 33736 backported then we can just ignore this situation. Otherwise we should maybe consider moving this specific patch on its own bug. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
