https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|[email protected] |[email protected] --- Comment #24 from Jonathan Druart <[email protected]> --- (In reply to Lucas Gass (lukeg) from comment #21) > (In reply to Jonathan Druart from comment #20) > > 1. There is an input in the first and last columns (checkbox and actions) > > > > 2. When I click on an input to give it the focus, a request is made to sort > > the column > > These problems should now both be fixed by obsoleting my follow-ups. Please > have a look now. Well it's actually for this change that I needed this for bug 36640 :D No worries, I will deal with that later. (In reply to Lucas Gass (lukeg) from comment #23) > (In reply to Jonathan Druart from comment #20) > > 1. There is an input in the first and last columns (checkbox and actions) > > > > 2. When I click on an input to give it the focus, a request is made to sort > > the column > > > > 3. This table is absolutely not ready for the "save state" feature (from bug > > 33484). We need to make it an exception: > > * Remove the 2 'save state' options from the Table settings admin page for > > this table. > > * Remove the "Copy shareable link" button > > * Bypass the save/load state callback functions for this table > > > > That will lead to some ugly code I have hardly tried to avoid on bug 33484 > > :D > > > > Or we remove what has been done on bug 14322 and adjust this table to make > > it work with the "save state" feature. > > > > I would move this to in discussion and see what we do next. I can help! > > I added a follow-up to make an exception for this table. We already have a > sharable link from Bug 14322. It's not correct. If you don't have save_state in the config you still want to offer the ability to share the state with the link. I will submit a follow-up. > I am happy to proceed in another direction if you want to try to implement > the work from Bug 33484, Jonathan. Yes, we should. But not here, not now :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
