http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755
Galen Charlton <gmcha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |In Discussion
CC| |gmcha...@gmail.com
--- Comment #18 from Galen Charlton <gmcha...@gmail.com> ---
Couple comments:
- Please rename the 'Koha::Record' class; as it is, the name is too generic.
After all, Koha has lots of record types, many of which are not MARC. I
suggest either 'Koha::MARC::Record' (following MARC::Record) or perhaps
'Koha::Metadata::MARC' (allowing for Koha::Metadata::MODS, etc.) or
'Koha::Util::MARC'.
- I think references to the 999 and 955 tags would be better handled by looking
up the tag that the MARC framework uses to store biblio.biblionumber rather
than using magic numbers.
Setting back to in discussion, as I do not intend to push this until (at least)
the class has a better name.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
