https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38484
--- Comment #11 from Jonathan Druart <[email protected]> --- This patch makes the filters look like other table's filters. So yes there is certainly a change in the style, but it's expected. (In reply to David Cook from comment #7) > Noting that the patch has added more filter boxes. > > Before patch, there were no boxes for Available collections, Earliest hold > date, Hold notes, and Action. > > Those first three are OK, but we probably don't want one on Action. Filter on action is not expected, patch coming. (In reply to David Cook from comment #8) > Comment on attachment 174806 [details] [review] > Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull" > > Review of attachment 174806 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt > @@ +1,2 @@ > > [% USE raw %] > > +[% USE To %] > > Does this line get used? I can't see it used anywhere. Unused, will be removed. > @@ +321,5 @@ > > }); > > } > > > > $(document).ready(function() { > > + [% SET libraries = Branches.all %] > > This line also seems unused? Unused, will be removed. > ::: koha-tmpl/intranet-tmpl/prog/js/datatables.js > @@ +808,4 @@ > > if ( !filters_options.hasOwnProperty(i) ) { > > filters_options[i] = eval(filter_type) > > } else if ( typeof filters_options[i] === "function" ) { > > + filters_options[i] = filters_options[i](table_dt) > > I don't know what this line does, but I'm going to assume it's OK. This page is different, we build the dropdown filters with the content of the table, not all the data in DB (what we need to do when using the REST API/ajax pagination). Here we pass the DataTable object so _dt_add_filters needs to loop over the columns of the table and retrieve its data. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
