https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360
--- Comment #26 from Marcel de Rooy <[email protected]> --- (In reply to Jake Deery from comment #25) > Hi Marcel, > > I believe it was due to triggering > Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations the old > way. Happy to put it back, if we think this is safe to ignore? Or is there > another way? :-) > > Jake. - my $value = $input->param($field); - $infos->{$field} = $value if $value; - $infos->{$field} = "" if grep { $_ eq $field } @disabled; I remember the conditional declaration, but the original code above does not contain that. Could we just put these lines back? Or was there any issue with empty string versus undef that you wanted to fix here? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
