https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #65 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> ---
Coming from 38531.
- my $diff = ( $original && ref $updated eq 'HASH' ) ? encode_json( diff(
$original, $updated, noU => 1 ) ) : undef;
+ my $diff = undef;
+ $diff = encode_json( diff( $original->unblessed, $updated, noU => 1 ) )
+ if blessed($original) && $original->isa('Koha::Object');
+ $diff //= encode_json( diff( $original, $updated, noU => 1 ) )
+ if $original && ref $updated eq 'HASH';
Would be nice to add some POD for this change? Bit obscure now imo.
Also note that this earlier line does not check $original:
if ( $infos->isa('Koha::Item') && $modulename eq 'CATALOGUING' &&
$actionname eq 'MODIFY' ) {
$infos = "item " . Dumper( $original->unblessed );
Feels suboptimal?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
