https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36039
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed Status|Passed QA |Failed QA --- Comment #32 from Katrin Fischer <[email protected]> --- I am hesitant to push this as is, as this will expose some useful, but also dangerous information to a lot more eyes. I'd like to work out some better display for the errors. This is unlikely to conflict, so I think we can take a little extra time to fix it up before push. 1) This includes some untranslatable strings that should be handled in the template: + print "Parsing schema for database '$database_name'\n" if $self->{is_cli}; + print "Parsing schema for file $self->{filename} \n" if $self->{is_cli}; We can move this to a separate bug if that helps. 2) Make the message easier to understand for people without code knowledge. + <h3>WARNING!!!</h3> + <p> + These commands are only suggestions! They are not a replacement for updatedatabase.pl!<br /> + Review the database, updatedatabase.pl, and kohastructure.sql before making any changes!<br /> + </p> We are referring to updatedatabase.pl here, but in package installations you will never encounter this script even as an update. Should we make the note more general maybe to make it also easier to understand? Suggestion: <p> These commands are only suggestions. There are not a replacement for the database update scripts run during installations and updates </p> <p> Review the database, the atomic update files and the table definitions in kohastructure.sql before making any changes.<p> I think better to create a visual warn with formatting than with many !. I'd also reduce to Warning! but maybe make it bold instead. <p>Following SQL statements might help in fixing your database. Review before use.</p> 3) Success message -- Convert schema '' to '':; -- No differences found; This doesn't look nicely formatted and also might be a bit confusing to some. Could we show some nice "All is well" type of note instead or at least remove the first line? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
