https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38646
--- Comment #9 from Michał <[email protected]> --- Awesome, thank you. I regret a bit not doing comparison benchmarks right away with the improved functions or not writing down how I got NYTProf working with Plack right away, while now I don't have access to the dev machine with the setup for some time. As for the tests, since you mention you want to expand them, a bit of a joke but a bit of actually serious idea: there could be some test that'd measure how many SQL queries some given function resulted in being made, or how long in total they took. That could have the potential to catch some regressions. Of course a simple example is this very function where a test could say it expects no more than say 5 sql queries to be run under it, rather than few hundred. But it could expand to some other more advanced code paths and call chains, where a regression suddenly causing something to be way less efficient could otherwise be much harder to catch (if some unrelated function suddenly calls something that would do many more queries down the call chain after a change, where at the time of coding the other function things were okay there). Would that make any sense? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
