https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694
--- Comment #20 from Nick Clemens (kidclamp) <n...@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #19) > (In reply to David Cook from comment #18) > > (In reply to Katrin Fischer from comment #17) > > > I think I see Joubu's point. As we plan to do the clean-up this cycle. Do > > > you see an advantage of continuing? > > > > Until the existing code is tidied, it's going to make patches harder to > > review. I think that's part of why we have separate tidy patches. > > > > I guess it all comes down to timing. In theory, if we do the tidy in the > > main patch, and the existing codebase gets tidied, that would probably yield > > fewer conflicts. > > > > Perhaps hypothetical fewer conflicts would be worth having a harder time > > reviewing for now... > > Not the place to discuss it but quick reply anyway: I have advised already > (several times) that I will provide a script to easy rebases and that you > should not worry about that. The tidy patches hitting main before the global > tidy will generate conflicts however, as the script won't be ready... Anyway > not a big deal, just ignore this if you disagree, and hopefully everything > will be tidy soon ;) I am happy not to tidy anymore ;-) I think too, separate patches mean the devs can provide (to make QA scripts green) and RM can ignore (to make Joubu green) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
